kie-issues#1779: Update deprecated react-json-view dependency #2870
+76
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoelg
approved these changes
Jan 23, 2025
thiagoelg
reviewed
Jan 23, 2025
| @@ -37,6 +37,7 @@ | |||
| "@kie-tools/i18n-common-dictionary": "workspace:*", | |||
| "@kie-tools/runtime-tools-components": "workspace:*", | |||
| "@kie-tools/runtime-tools-shared-gateway-api": "workspace:*", | |||
| "@microlink/react-json-view": "^1.24.0", | |||
There was a problem hiding this comment.
It looks like this dependency is not used in this package; maybe it could be removed?
ljmotta
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
@kbowers-ibm Thanks for this change! @microlink/react-json-view is a fork of the previous library. I don't think we should have any problems with this change.
yesamer
approved these changes
Jan 23, 2025
tiagobento
added
the
area:dependencies
|
@kbowers-ibm Conflicts... 🙈 |
tiagobento
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator-kie-issues#1779
Replacing the deprecated https://github.com/mac-s-g/react-json-view with https://github.com/microlinkhq/react-json-view (recommended by author of the deprecated dependency)